Manpages: podman network connect missing example with --mac-address option#26407
Manpages: podman network connect missing example with --mac-address option#26407openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom shu-kitamura:example_mac-address
Conversation
|
Thanks, you will have to add a DCO signoff to the commit message see https://github.com/containers/podman/blob/main/CONTRIBUTING.md#sign-your-prs Also if you are going to repush it would be nice to add the |
Signed-off-by: shu-kitamura <shusei3316@yahoo.co.jp>
|
Thanks for your check. |
Luap99
left a comment
There was a problem hiding this comment.
LGTM
FYI the Fixes: #xxx should generally go on a separate line at the end of the commit and not as part of the title but that is not a blocker.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, shu-kitamura The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Luap99 May I ask a question? I have read the code review process. I understand that PRs are merged in the following way:
Currently, the |
Yes, the process requires a second lgtm where the |
|
/lgtm |
547de92
into
containers:main
Hello!
I added example with
--mac-addressoption forpodman network connectFixes: #26374
Does this PR introduce a user-facing change?
None